Refactor OpenReac optimization tests #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
p-arvy
changed the title
7 tasks
|
So-Fras
requested changes
Dec 20, 2024
| /** | ||
| * Runs OpenReac and apply the results on the network. | ||
| */ | ||
| void runAndApplyAllModifications(Network network, String subFolder, OpenReacParameters parameters, |
There was a problem hiding this comment.
Why not adding the protected keyword here?
| * Add voltage limits to voltage levels with undefined limits. | ||
| * OpenReac needs voltage limits to run optimization. | ||
| */ | ||
| void setDefaultVoltageLimits(Network network) { |
There was a problem hiding this comment.
Same remark, why not adding the protected keyword?
| assertEquals(-4.698, network.getBusBreakerView().getBus("BUS_3").getAngle(), 0.001); | ||
| } | ||
|
|
||
| public static Network create() { |
There was a problem hiding this comment.
Is there a reason why the method is public?
There was a problem hiding this comment.
It is a bit confusing that this method is named the same than another one in ShuntNetworkFactory (also used in tests).
So maybe change the public into a private and change the name into a more explicit one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
The optimization tests of OpenReac are refactored.
What is the current behavior?
All the tests are in the same file.
What is the new behavior (if this is a feature change)?
The tests have been divided into several files.
This will facilitate the adding of new tests in the future.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: